Hotfix - NPE crash in RouterServiceProvider #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @Override | ||
| public void handleMessage(Message msg) { | ||
| if(this.provider == null || this.provider.get() == null){ |
There was a problem hiding this comment.
Could make this.provider variable final, initialize it once in constructor and not to check for (this.provider == null) each time after. Only this.provider.get() can actually be null.
Member
Author
There was a problem hiding this comment.
Yes that's a better idea
|
seems good) waiting for the fix to be merged |
|
Can we ship it, please?? It's really urgent, ton of crashes in production =( |
mrapitis
added
REVIEW - accepted
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #365
Also fixed a few other obvious issues along the same line in the SdlRouterService.