New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for Rails 5 release #306

Merged
merged 8 commits into from Jul 8, 2016

Conversation

Projects
None yet
9 participants
@smartinez87
Copy link
Owner

smartinez87 commented Dec 22, 2015

This PR prepares us to support Rails 5 once it's released.

Tasks

  • remove.beta1 from dependencies

@smartinez87 smartinez87 added this to the v5.0.0 milestone Dec 22, 2015

s.authors = ["Jamis Buck", "Josh Peek"]
s.date = %q{2015-12-04}
s.date = %q{2015-12-28}

This comment has been minimized.

@san650 san650 referenced this pull request Jan 8, 2016

Closed

Not compatible with rails 5 #304

@clemensg

This comment has been minimized.

Copy link

clemensg commented Jan 26, 2016

Hi @smartinez87,

because you locked rails to '5.0.0.beta1' in your gemspec, the security fix from today can't be applied (rails beta was bumped to 5.0.0.beta1.1: http://weblog.rubyonrails.org/2016/1/25/Rails-5-0-0-beta1-1-4-2-5-1-4-1-14-1-3-2-22-1-and-rails-html-sanitizer-1-0-3-have-been-released/).

Could you please change the rails dependencies in the gemspec of the rails5 branch to: gem.add_dependency "foo", ">= 5", "< 6" or something similar?

Thanks.

@smartinez87 smartinez87 force-pushed the rails5 branch 2 times, most recently from 2765d3f to 4829885 Jan 28, 2016

@smartinez87

This comment has been minimized.

Copy link
Owner

smartinez87 commented Jan 28, 2016

@clemensg you should be able to use the latest beta now

@clemensg

This comment has been minimized.

Copy link

clemensg commented Jan 28, 2016

Thank you, @smartinez87 !

@doits

This comment has been minimized.

Copy link

doits commented Feb 9, 2016

You can also use dependency on rails with ~> 5.x which does include beta and official versions afaik.

@aried3r

This comment has been minimized.

Copy link

aried3r commented Feb 12, 2016

Will support for Rails 4 actually be dropped as the README in this PR suggests? I don't see any breaking changes?

@doits

This comment has been minimized.

Copy link

doits commented Mar 3, 2016

Any chance to release this as beta version to rubygems?

@bogdanRada

This comment has been minimized.

Copy link

bogdanRada commented May 24, 2016

any update on this? Will support for Rails 4 actually be dropped as the README in this PR suggests? when can be expect a new rubygems release? it has been almost 2 months since last comment on this thread.

@koic

This comment has been minimized.

Copy link

koic commented Jul 1, 2016

Rails 5.0.0 has been released 🎉
How is the progress on this?

@smartinez87 smartinez87 force-pushed the rails5 branch from c3000b7 to 3efba33 Jul 2, 2016

@smartinez87 smartinez87 force-pushed the rails5 branch from 3efba33 to acc81dc Jul 2, 2016

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 2, 2016

Coverage Status

Coverage increased (+0.005%) to 94.222% when pulling f2e0884 on rails5 into 4d6adef on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 2, 2016

Coverage Status

Coverage increased (+0.005%) to 94.222% when pulling f2e0884 on rails5 into 4d6adef on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 2, 2016

Coverage Status

Coverage decreased (-0.09%) to 94.129% when pulling 4a88cc3 on rails5 into 4d6adef on master.

@aried3r

This comment has been minimized.

Copy link

aried3r commented Jul 4, 2016

I think if we bump Ruby 2.2 to 2.2.4 on Travis, most of the issues on Travis-CI (wrt to Rails 5) should be resolved. For the versions Ruby <2.2.2, we need to explicitly require rack <2, I think.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 6, 2016

Coverage Status

Coverage decreased (-0.09%) to 94.123% when pulling 21f2375 on rails5 into 4d6adef on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 6, 2016

Coverage Status

Coverage decreased (-0.5%) to 93.744% when pulling a0ddc19 on rails5 into 4d6adef on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 6, 2016

Coverage Status

Coverage decreased (-0.09%) to 94.129% when pulling a9ec101 on rails5 into 4d6adef on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 6, 2016

Coverage Status

Coverage decreased (-0.09%) to 94.129% when pulling ff27f86 on rails5 into 4d6adef on master.

@alpaca-tc

This comment has been minimized.

Copy link

alpaca-tc commented Jul 7, 2016

👍 Great fix.

@smartinez87 smartinez87 merged commit f9b1669 into master Jul 8, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@smartinez87 smartinez87 deleted the rails5 branch Jul 8, 2016

@smartinez87 smartinez87 changed the title [WIP] prepare for Rails 5 release prepare for Rails 5 release Jul 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment