Remove dependency on Rails #336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gem does not work well with Sinatra (despite description in the readme), because email templates use [Time.current][1] call that is available only in active support. This PR removes the dependency by using Time.now instead. [1]: http://apidock.com/rails/v4.1.8/Time/current/class
|
thanks @skrobul for contributing. Can you please check the failing tests? |
|
@smartinez87 apologies for the delay - this PR went completely out of my radar. I see that it has been fixed in HEAD already, so I am going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gem does not work well with Sinatra (despite description in the readme),
because email templates use Time.current call that is available only in
active support.
This PR removes the dependency by using Time.now instead.