cleanup #1

merged 7 commits into from Jan 14, 2013


None yet
2 participants

No description provided.


smartiniOnGitHub commented Jan 14, 2013

Hi Burt, thank you very much for the extensive review/cleanup of the plugin.
I have to say that I'd prefer to keep some commented code, as a reference and mainly for enabling future enhancements (and the same even for some folders currently empty).
The unification of test sources looks good, but after the pull I have to rename the package to something like grails_akka_test and exclude only it from plugin packaging, because in next releases I'm thinking to add some Groovy code to the plugin under the package grails_akka.
For example, I'm still trying to verify it could be good for the plugin to implement an AkkaSystem so applications could have it injected. And I'm still guessing how to find a Grails-like way to run a remote akka system and connect to it during plugin integration tests, but this is another issue ... but maybe could stay a detail unrelated to Grails tests.

In short, now I accept all this pull request from you, and in next days I'll do my other little changes.

Again, thanks for this, and of course you are welcome to do other fix/enhancements whenever you want.

smartiniOnGitHub added a commit that referenced this pull request Jan 14, 2013

@smartiniOnGitHub smartiniOnGitHub merged commit e3b4d84 into smartiniOnGitHub:master Jan 14, 2013

The commented stuff is still in Git, so it's easy to retrieve, but of course back out any changes I made - that's why I did several smaller commits instead of one big one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment