From 626d1b0995cefdad4bfa5899939554284496802a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christoph=20B=C3=BChler?= <buehler@users.noreply.github.com>
Date: Mon, 26 Mar 2018 15:28:09 +0200
Subject: [PATCH] feat(rule-set): Add member access as well as function name
 (#4)

BREAKING CHANGE: This adds `member-access` as a required rule.
This rule forces the user to add `public`, `private` and `protected` modifiers
to their class members. To migrate, install the new version and use the
given visibility members on classes.
---
 README.md         | 18 ++++++++++++++++++
 tslint-react.json | 13 ++++++++++++-
 tslint.json       |  3 ++-
 3 files changed, 32 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index fe2b3a8..816b2a5 100644
--- a/README.md
+++ b/README.md
@@ -36,11 +36,18 @@ developers, but can become relevant if `x` can be `true | false | null`.
 *This rule only works if [Type Information / Checking is available](https://palantir.github.io/tslint/rules/no-boolean-literal-compare/).*
 
 ### No Strict Boolean Expressions
+
 With `strict-boolean-expressions` only boolean values can be used with `!`, `&&`, `||`, ternary operators, if conditions and loops.
 JavaScript allows quite a few neat shorthand expressions with non-boolean value, which we don't want to prohibit.
 
 *This rule only works if [Type Information / Checking is available](https://palantir.github.io/tslint/rules/no-boolean-literal-compare/).*
 
+### Member Access
+
+Force the user to add `public`, `protected` and `private` information to the
+members of a class. This leads to better readability (despite the default
+of `public`).
+
 ## Usage
 
 Install using NPM:
@@ -95,5 +102,16 @@ like Code Reviews, to prevent an increase in unreadable code.
 Sometimes filenames are not very meaningful and developers should be allowed to change default import statements, as they have the
 same possibility with aliases for named imports (`import { Foo as Bar } from 'foo';`).
 
+### JSX No Lambda
+
+Since there are very little performance impacts on lambda expressions in jsx,
+we decided to allow lambdas in jsx props.
+
+### Function Name
+
+If you use default exports, you can name your exported function with a capital
+letter. This leads to a better understanding of several IDE tools.
+`export default function Link() ...`
+
 ## Release notes
 The release notes can be found in the [release section](https://github.com/smartive/tslint-config/releases).
diff --git a/tslint-react.json b/tslint-react.json
index d86eefb..24c2ccf 100644
--- a/tslint-react.json
+++ b/tslint-react.json
@@ -10,6 +10,17 @@
     ],
     "jsx-boolean-value": ["never"],
     "jsx-no-multiline-js": false,
-    "import-name": false
+    "jsx-no-lambda": false,
+    "import-name": false,
+    "function-name": [
+      true,
+      {
+        "function-regex": "/^([a-z$]|[A-Z$][a-z\\d])[\\w\\d]+$/",
+        "method-regex": "/^[a-z$][\\w\\d]+$/",
+        "private-method-regex": "/^[a-z$][\\w\\d]+$/",
+        "protected-method-regex": "/^[a-z$][\\w\\d]+$/",
+        "static-method-regex": "/^[a-z$][\\w\\d]+$/"
+      }
+    ]
   }
 }
diff --git a/tslint.json b/tslint.json
index 35c91d4..e7524ca 100644
--- a/tslint.json
+++ b/tslint.json
@@ -27,6 +27,7 @@
       "allow-leading-underscore"
     ],
     "no-boolean-literal-compare": false,
-    "strict-boolean-expressions": false
+    "strict-boolean-expressions": false,
+    "member-access": true
   }
 }