Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Do not hide multi-selectable filters of the same group if there are no hits #1187

Closed
iherwald opened this issue Jun 24, 2017 · 4 comments
Assignees
Labels
Milestone

Comments

@iherwald
Copy link

iherwald commented Jun 24, 2017

Filter options for "brands" and "delivery times" are correctly rendered for multi selection as "check boxes" but are behaving like "radio buttons". Only selection of one option is possible.

@mgesing
Copy link
Contributor

mgesing commented Jun 26, 2017

Could you please provide more details? I cannot reproduce it.

@iherwald
Copy link
Author

In the Community Edition v3.0.1 multi selection of filter options is not possible.

However, in the demo store "http://demo.smartstore.com/frontend" multi selection of check boxes is working as expected.

@mgesing
Copy link
Contributor

mgesing commented Jun 26, 2017

I cannot reproduce that. Works as expected. Manufacturers and delivery times are filtered "or-combined".

@mgesing mgesing closed this as completed Jun 26, 2017
@iherwald
Copy link
Author

The root cause for the described behaviour in Community Edition is, that all manufactures existing in the shop are listed as brand filter options, regardless which category and other filter options are currently active.

I guess this is due to limitations in the Community Edition (?)
However, as a user you have to get grip on it first.

But nevertheless this results in an inconsistent behaviour:

  • If the user first selects a brand option that none of the products in the active category and other filter options can fulfill, all other brand options are removed.
  • If the user first selects a brand option that at least one of the products in the active category and other filter options can fulfill, all other brand options remain and are selectable.

Steps to test it with Community Edition:

Download and extract SmartStoreNET Community v3.0.1:
https://github.com/smartstoreag/SmartStoreNET/releases/download/3.0.1/SmartStoreNET.Community.3.0.1.zip
Run SmartStoreNET in WebMatrix
Create new SQL Server Express database and install SmartStoreNET with sample data

Test A:

  1. Select category "Sports"
  2. Select "Brand" filter option "Acer"
    -> Results in: all other brand options are removed.

Remove all filters

Test B:

  1. Select category "Sports"
  2. Select "Brand" filter option "Adidas"
  3. Select "Brand" filter option "Acer"
    -> Results in: all other brand options remain and are selectable.

@mgesing mgesing changed the title Multi select of filter options is not possible (e.g. brand, delivery time) Search: Do not hide multi-selectable filters of the same group if there are no hits Jun 27, 2017
@mgesing mgesing self-assigned this Jun 27, 2017
@mgesing mgesing added this to the 3.1 milestone Jun 27, 2017
@mgesing mgesing reopened this Jun 27, 2017
@mgesing mgesing added search and removed frontend labels Jun 28, 2017
@mgesing mgesing modified the milestones: 3.0.2, 3.1 Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants