Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product tag count should filter also based on VisibleIndividually #1730

Closed
altmoola opened this issue Oct 22, 2019 · 2 comments
Closed

Product tag count should filter also based on VisibleIndividually #1730

altmoola opened this issue Oct 22, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@altmoola
Copy link

altmoola commented Oct 22, 2019

It's odd to see a product tag count of 4 when only 3 of those products are visible individually. That means you click the tag that says 4 and only 3 products appear.

@altmoola
Copy link
Author

altmoola commented Oct 22, 2019

From ProductTagService:

where (!p.LimitedToStores || storeId == sm.StoreId) && !p.Deleted && p.Published && p.VisibleIndividually

From the very lonely SP [dbo].[ProductTagCountLoadAll]:

WHERE
	p.[Deleted] = 0
	AND p.Published = 1
	AND p.VisibleIndividually = 1

@mgesing mgesing self-assigned this Oct 22, 2019
@mgesing mgesing added the review label Oct 22, 2019
@mgesing mgesing added this to the 4.0 milestone Oct 22, 2019
@mgesing mgesing added bug and removed review labels Oct 28, 2019
@mgesing
Copy link
Contributor

mgesing commented Oct 28, 2019

When working with 4.x update-database -TargetMigration Merge5 must be executed to take effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants