New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursively ignore folders #345

Closed
pjoe opened this Issue Sep 17, 2015 · 16 comments

Comments

Projects
None yet
8 participants
@pjoe
Copy link

pjoe commented Sep 17, 2015

I know that are profiles that can ignore individual packages, but they do not recursively ignore.

My use case has the following reasons for a better way to ignore folders (something like .gitignore):

  • Using go 1.5 vendoring (i.e. vendoring to a vendor folder, which I want to be able to ignore)
  • Having frontend stuff using bower and node also creates subfolders with tons of stuff (bower_components and node_modules) that there is no reason for goconvey to traverse
@mdwhatcott

This comment has been minimized.

Copy link
Member

mdwhatcott commented Sep 17, 2015

Great points. Your use case is becoming more and more common amongst goconvey users. Maybe this could be implemented as an extension of the currently supported profiles?

@pjoe

This comment has been minimized.

Copy link
Author

pjoe commented Sep 17, 2015

Possibly :)

I would prefer if the ignore setting can be done in the parent folder (maybe in it's profile), as e.g. for bower_components and node_modules I sometimes end up removing both folders and reinstalling those - which would break if their ignore settings were inside.

@pjoe

This comment has been minimized.

Copy link
Author

pjoe commented Sep 17, 2015

I will try taking a quick look, which branch do you prefer PR's against, master?

@mdwhatcott

This comment has been minimized.

Copy link
Member

mdwhatcott commented Sep 17, 2015

Yes, use the master branch.

@brocaar

This comment has been minimized.

Copy link

brocaar commented Oct 7, 2015

Would it make sense to add the possibility to specify a list of packages to the goconvey cli tool? This would be in line with the go test command. To work around the issue of the vendor/ folder, e.g. I'm currently using go test go list ./... | grep -v /vendor/`` to run my tests and ignore the vendored packages.

@mdwhatcott

This comment has been minimized.

Copy link
Member

mdwhatcott commented Oct 7, 2015

@brocaar - yes, that's one way to go about it and it could work. Keep in mind that the web UI allows you to move the runner around to different directories (by editing the path near the top of the screen). Would the list of packages follow the runner to different file system locations?

@thomasmodeneis

This comment has been minimized.

Copy link

thomasmodeneis commented Oct 14, 2015

Hi, @brocaar thanks for the tip, does this works as well for the WEB runner ?

Cheers.

@brocaar

This comment has been minimized.

Copy link

brocaar commented Oct 14, 2015

The problem (I realise now) is that the web ui expects a path, rather than a list of packages as go test does. I think when mixing these two concepts together in goconvey, things might get a bit complex to grasp / overcomplicate things.

@Keats

This comment has been minimized.

Copy link

Keats commented Oct 25, 2015

Anyone using goconvey with gb successfully?

Edit: ended up running it like so

PROJECT_DIR=`pwd`
cd src/my_project
GOPATH="$PROJECT_DIR/vendor:$PROJECT_DIR" goconvey -packages=1 &
@mdwhatcott

This comment has been minimized.

Copy link
Member

mdwhatcott commented Oct 26, 2015

Yeah, that's a creative workaround. (It would break down if your project has several layers of nested packages/folders, hence the need for something better.)

@vrecan

This comment has been minimized.

Copy link

vrecan commented Oct 26, 2015

this issue seems to be biting me as well, I am using go 1.5 vendoring and goconvey tends to lock up.

@meAmidos

This comment has been minimized.

Copy link

meAmidos commented Dec 2, 2015

I have just encountered the same issue. There is a temporary solution:

cd myproject
goconvey -depth=1

However, something more general is needed to address the issue completely.

@DallanQ

This comment has been minimized.

Copy link

DallanQ commented Jan 13, 2016

It appears that this has been addressed by f1f43ec - is that correct?

@mdwhatcott

This comment has been minimized.

Copy link
Member

mdwhatcott commented Jan 13, 2016

Yes, it would seem @DallanQ. Can you confirm @pjoe ?

@pjoe

This comment has been minimized.

Copy link
Author

pjoe commented Jan 14, 2016

@mdwhatcott: seems to be working for me, though I would suggest also adding bower_components to the default

@mdwhatcott

This comment has been minimized.

Copy link
Member

mdwhatcott commented Jan 14, 2016

@pjoe - Anyone is welcome to submit that as a default in a separate PR.

I'll close the issue then. Feel free to re-open if there are continuing issues.

@mdwhatcott mdwhatcott closed this Jan 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment