Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer updates #42

Closed
wants to merge 3 commits into from
Closed

Installer updates #42

wants to merge 3 commits into from

Conversation

@leonelgalan
Copy link
Contributor

@leonelgalan leonelgalan commented Feb 2, 2015

Run tape installer dependencies every time you install*/update tape

install*: tape installer install will run this for you, but developers that didn't ran it on their computers need to install dependencies in order to use tape appropriately.

@leonelgalan
Copy link
Contributor Author

@leonelgalan leonelgalan commented Feb 5, 2015

I pushed this after 0.3.0 as 0.3.1. Needs to be rebased in order to work with the latest merged code.

@BrandonMathis
Copy link
Contributor

@BrandonMathis BrandonMathis commented Feb 10, 2015

Pretty sure any functionality introduced by this change in already in tape.

Close?

@leonelgalan
Copy link
Contributor Author

@leonelgalan leonelgalan commented Feb 10, 2015

It is, this was an improvement on top of what we had. Still valid, it just needs rebase.

@BrandonMathis
Copy link
Contributor

@BrandonMathis BrandonMathis commented Feb 10, 2015

I don't see any improvements that have not already been added to tape

@leonelgalan
Copy link
Contributor Author

@leonelgalan leonelgalan commented Feb 10, 2015

The tape installer dependencies action: https://github.com/smashingboxes/tape/blob/0.3.1/lib/tape/installer.rb#L5 and allowing to specify tags on be ansible tape: https://github.com/smashingboxes/tape/blob/0.3.1/bin/tape#L40

@leonelgalan leonelgalan force-pushed the installer_updates branch from 7ecc728 to f9c18ed Feb 11, 2015
@leonelgalan
Copy link
Contributor Author

@leonelgalan leonelgalan commented Feb 11, 2015

Rebased, this adds bundle exec tape installer dependencies, which could help Reed on #45

@BrandonMathis
Copy link
Contributor

@BrandonMathis BrandonMathis commented Feb 12, 2015

niiiiiiice

leonelgalan added a commit that referenced this issue Feb 13, 2015
@dkniffin dkniffin deleted the installer_updates branch Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants