Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: don't count disabled elements as clickable #27

Merged

Conversation

@faso
Copy link
Collaborator

commented Aug 14, 2019

Today while writing some tests I assumed that searching for 'clickable' elements wouldn't return disabled inputs, textareas, etc. However, it does.

That's why I propose this small change to the behavior of the 'clickable' elementfinder prop.

Changes:

  • added a !disabled condition to elementfinder.js
  • added a test to elementfinder.smash
@faso faso requested a review from vptes1 Aug 14, 2019
Copy link
Collaborator

left a comment

Good idea. Totally agree, and this is highly unlikely to break anyone's existing test.

tests/packages/elementfinder.smash Show resolved Hide resolved
@faso faso requested a review from vptes1 Aug 14, 2019
@vptes1
vptes1 approved these changes Aug 14, 2019
@vptes1 vptes1 merged commit 9e2bf17 into smashtestio:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.