Skip to content

Navigate the frames of a stacktrace. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Aug 24, 2014
Merged

Navigate the frames of a stacktrace. #7

merged 25 commits into from
Aug 24, 2014

Conversation

@smashwilson
Copy link
Owner

@smashwilson smashwilson commented Jul 31, 2014

While a trace is active, allow navigation up and down the call stack with a NavigationView that attaches to the bottom of the workspace.

  • Create a panel view and attach it to the bottom of the workspace.
  • Show the name of the active stacktrace. If there is no active stacktrace, hide the view, but don't destroy it.
  • Navigate back to the StacktraceView.
  • Allow the stacktrace to be deactivated.
    • Remove the activation controls from the StacktraceView, it makes more sense here.
  • Show the current frame and its position within the trace.
  • Navigate to the next and previous frames.
  • Notices if you manually navigate to a different frame, within the same editor or a new one.
  • Distinguish visually between being right on a frame and having moved off of one, but not onto another yet.
  • Navigate to the last active frame.

smashwilson added 25 commits July 31, 2014 11:11
@smashwilson
Spec-first.
244995d
@smashwilson
More specs for the multiple-frame case.
77d03df
@smashwilson
Attach the navigation view to the workspace.
1e3e03c
@smashwilson
Tests for displaying the active trace.
0fd987c
@smashwilson
Toggle the "inactive" class on trace activation.
c8ccf25
@smashwilson
Upgrade line-chomper.
0750ad3
@smashwilson
Open the active Stacktrace when clicking the message.
ed36087
@smashwilson
Actually register the trace.
49161ce
@smashwilson
Improve the CSS selectors to target new markup.
6e6f669
@smashwilson
Deactive a trace with the "x" button.
ddc93be
@smashwilson
Hide the navigation panel if there's no trace.
e5525a1
@smashwilson
Remove the activation controls from StacktraceView.
726346a
@smashwilson
Tests for showing information about the frame.
426b28a
@smashwilson
Stacktrace and Frame recognize Editor positions.
bed65f2
@smashwilson
Comment touchups 💄
668aec2
@smashwilson
Show the current frame on the NavigationView.
7188353
@smashwilson
Fuss with styles.
b02fa7f
@smashwilson
Give precedence to already-focused frames.
f372a68
@smashwilson
Assign indices to frames on Trace construction.
6bd63c5
@smashwilson
Access callers and callees of stack frames.
d18f195
@smashwilson
Just return a Frame from atEditorPosition.
c8a8f60
@smashwilson
Navigate to caller and callee of a frame.
e0fa818
@smashwilson
Add buttons for stack navigation.
8316fa7
@smashwilson
Navigate back to the last active frame.
e504089
@smashwilson
Get those tests passing.
e3c8b3e
@smashwilson smashwilson changed the title [wip] Navigate the frames of a stacktrace. Navigate the frames of a stacktrace. Aug 24, 2014
smashwilson added a commit that referenced this pull request Aug 24, 2014
@smashwilson
Merge pull request #7 from smashwilson/navigation-panel
22687f0 
Navigate the frames of a stacktrace.
@smashwilson smashwilson merged commit 22687f0 into master Aug 24, 2014
@smashwilson smashwilson deleted the navigation-panel branch August 24, 2014 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@smashwilson