added /api/dailyjobs/{uid}/incidentTickets/{id} end point

[Bertievh]

Added new incidentTickets endpoint to DailyJobs as required by ServiceNow and EasyVista connectors to update value with received ticket id and url values.

[pinonpierre]

Hi,
Can you:

• Fix PR comments please
• Create issue and link it to this PR

Thanks

[Bertievh]

Hi Pierre, Will update. However, will wait until they have missing POST function. Bertie Bertie Vanhinsbergen Principal Automation Consultant Ziegelbrückstrasse 82 | 8866 Ziegelbrücke Office: +41 556173645 | Direct: www.SMAtechnologies.com | bvanhinsbergen@smatechnologies.com The information contained in this e-mail and any accompanying documents may contain information that is confidential or otherwise protected from disclosure. If you are not the intended recipient of this message, or if this message has been addressed to you in error, please immediately alert the sender by reply e-mail and then delete this message, including any attachments. Any dissemination, distribution or other use of the contents of this message by anyone other than the intended recipient is strictly prohibited.​ ​ ​ From: Pierre PINON <notifications@github.com> Sent: Monday, 14 December 2020 09:53 To: SMATechnologies/opcon-rest-api-client-java <opcon-rest-api-client-java@noreply.github.com> Cc: Bertie Vanhinsbergen <bvanhinsbergen@smatechnologies.com>; Author <author@noreply.github.com> Subject: Re: [SMATechnologies/opcon-rest-api-client-java] added /api/dailyjobs/{uid}/incidentTickets/{id} end point (#51) @pinonpierre requested changes on this pull request. Hi, Can you: * Fix PR comments please * Create issue and link it to this PR Thanks

________________________________ In src/main/java/com/smatechnologies/opcon/restapiclient/model/dailyjob/details/IncidentTicketDetails.java<#51 (comment)>:

+ public static final String TICKET_ID = "ticketId";

+ public static final String TICKET_URL = "ticketUrl"; For consistency, can you rename to: * PROPERTY_TICKET_ID * PROPERTY_TICKET_URL

________________________________ In src/main/java/com/smatechnologies/opcon/restapiclient/model/dailyjob/details/IncidentTicketDetails.java<#51 (comment)>:

+package com.smatechnologies.opcon.restapiclient.model.dailyjob.details;

+ +public class IncidentTicketDetails { + + public static final String RESOURCE = "incidentTickets"; + + public static final String PROPERTY_ID = "id"; + public static final String TICKET_ID = "ticketId"; + public static final String TICKET_URL = "ticketUrl"; + + private String id; + private String ticketId; + private String ticketUrl; + + public String getId() { + return id; Please utilise formatter on all your files: * Tabs are forbidden and must be spaces * A lot of useless duplicated empty lines

________________________________ In src/main/java/com/smatechnologies/opcon/restapiclient/model/dailyjob/details/IncidentTicketDetails.java<#51 (comment)>:

+ public String getTicketId() {

+ return ticketId; + } + + public void setTicketId(String ticketId) { + this.ticketId = ticketId; + } + + public String getTicketUrl() { + return ticketUrl; + } + + public void setTicketUrl(String ticketUrl) { + this.ticketUrl = ticketUrl; + } + equals and hashcode missing — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#51 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOSPB5A2SK3BDYJTL3ODNWDSUXG5ZANCNFSM4UZMDC4A>.

[Bertievh]

Corrected definitions and pushed to origin

[Bertievh]

The POST request has been delayed, so maybe better to add these new endpoints now