Sean McGregor smcgregor

Organizations

@privly
smcgregor commented on pull request privly/privly-applications#225
@smcgregor

I still see 5 commits. Are you not going to squash?

@smcgregor
smcgregor merged pull request privly/privly-safari#11
@smcgregor
Added gitignore
1 commit with 3 additions and 0 deletions
@smcgregor

How is the submit button in the modal have Chinese UI? Did you do localization or pull from the host page? In the second video, it looks like the …

@smcgregor

+1

@smcgregor
smcgregor merged pull request privly/privly-safari#10
@smcgregor
Shortened comment for data-privly-accept-resize
1 commit with 1 addition and 2 deletions
smcgregor commented on pull request privly/privly-applications#225
@smcgregor

I believe you squashed the commits after you rebased on master. This means you pulled in changes that were made on master, then you squashed these …

@smcgregor

The lack of web standards strikes again. What about pages that don't allow inline scripts? ('unsafe-inline') https://developer.mozilla.org/en-US/do…

smcgregor commented on pull request privly/privly-applications#179
@smcgregor

I think you might be limited to unit testing until an app implements the API.

smcgregor commented on pull request privly/privly-applications#225
@smcgregor

The pull request still has 11 commits on it. Is this the case when you look at the history of your branch locally?

@smcgregor
@smcgregor
Added test for set and remove Objects from localStorage.
1 commit with 25 additions and 14 deletions
@smcgregor

Content that is pending deletion will show up in the History table, but you won't be able to make any changes to it. The production content server …

@smcgregor

I would guess that Chrome content script generated events don't fire in the host page's scripting context. We may need to add the script to the hos…

@smcgregor
Removing html2js hack
1 commit with 34 additions and 27 deletions
@smcgregor

Are you talking about its entry in the history application's table? That should be removed when the content server's content is destroyed. Is it not?

@smcgregor

"Web applications should use constructor instead of this if it's available." Looks like we should swap to the new syntax?

smcgregor commented on pull request privly/privly-applications#225
@smcgregor

I think so, but it is difficult to say for certain without more time investment. I think you should push the changes to remote and we'll see what h…

@smcgregor
@smcgregor
Add basic typography for injected view
1 commit with 434 additions and 1 deletion
smcgregor commented on pull request privly/privly-applications#231
@smcgregor

I think you can squash all your commits on this pull request into a single commit.

@smcgregor
smcgregor merged pull request privly/privly-safari#8
@smcgregor
Updated README
1 commit with 59 additions and 5 deletions
@smcgregor
Update Readme
@smcgregor

What are you referring to when you say "injected environment"? Are you talking about a content script?

@smcgregor

I believe some of the forms on facebook were particularly challenging, but I don't remember which one it was -- and it has likely since changed.

@smcgregor

This took considerable reverse engineering, but the reason we issue this series of events is that certain websites have a very complex series of ac…

@smcgregor

Looks good to me. @buckinha: Does this look good to you? I think this pulls in some changes you have made subsequently on your fork.