Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wechat and alipay #106

Merged
merged 1 commit into from Nov 28, 2016
Merged

add wechat and alipay #106

merged 1 commit into from Nov 28, 2016

Conversation

MartinForReal
Copy link
Contributor

Could you please help review the change? Thanks!

Copy link
Collaborator

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zimbatm zimbatm merged commit 0cc1f81 into smcllns:master Nov 28, 2016
@winniehell
Copy link
Contributor

@MartinDlut @zimbatm This is how the buttons look for me on current master. Do they look different on your systems?
buttons

@winniehell
Copy link
Contributor

It seems like WeChat and AliPay are the only SVGs with colors. Also both consists only of an embedded PNG while the other icons seem to be vectors.

cc @smcllns

zimbatm added a commit that referenced this pull request Jan 24, 2017
This reverts commit 0cc1f81.

Icons weren't displaying properly
@zimbatm
Copy link
Collaborator

zimbatm commented Jan 24, 2017

@MartinDlut I'm sorry but I had to revert your contribution, the icons weren't displaying properly for me either

@zimbatm
Copy link
Collaborator

zimbatm commented Jan 24, 2017

I don't have the time to fix the contribution so that's why I'm reverting. If you submit a fixed version I will happily have them merged again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants