Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install-deps.sh: recognize linuxmint #211

Merged
merged 1 commit into from Feb 28, 2018
Merged

Conversation

crackcomm
Copy link
Contributor

Script works on Linux Mint fine, we can include it too.

Script works on Linux Mint fine, we can include it too.
@emaxerrno
Copy link
Collaborator

LGTM.

@emaxerrno emaxerrno merged commit 4e0bbd8 into smfrpc:master Feb 28, 2018
@emaxerrno
Copy link
Collaborator

also, @crackcomm - thank you for your first PR! w00t. Hope it was easy to contribute. Let me know if you need help getting started or have any issues getting up and running.

@crackcomm
Copy link
Contributor Author

crackcomm commented Feb 28, 2018

I actually do, should I build the smf with seastar on master? here's my ./debug log. c++ (Ubuntu/Linaro 6.3.0-18ubuntu2~16.04) 6.3.0 20170519.

Edit: maybe it's flatc version 1.8.0 (Feb 22 2018 19:41:29) incompatibility?

@emaxerrno
Copy link
Collaborator

what compiler are you using ?

I think it's a compiler bug.

@emaxerrno
Copy link
Collaborator

I'm using this

 agallego@mountdoom  ~/workspace/smf   master ●  gcc --version    
gcc (GCC) 7.3.1 20180130 (Red Hat 7.3.1-2)
Copyright (C) 2017 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


@emaxerrno
Copy link
Collaborator

I don't think is flatc... it looks like the compiler can't deduce a this->hist_->automeasure() which is the thing that tracks latency distributions.

../src/rpc/rpc_server.cc:161:22: error: cannot call member function ‘seastar::future<> smf::rpc_server::dispatch_rpc(seastar::lw_shared_ptr<smf::rpc_server_connection>, smf::rpc_recv_context&&)’ without object
                     .finally([m = hist_->auto_measure()]{});

If you post your compiler version, i can help you get up and running.

@emaxerrno
Copy link
Collaborator

can you file a separate issue for this, and we can track it there. Thanks!

hellertime pushed a commit to hellertime/smf that referenced this pull request Jun 13, 2018
Script works on Linux Mint fine, we can include it too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants