fix(rt): reserve behavior with existing data; add new convenience wrappers #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbotsf
approved these changes
May 27, 2021
Comment on lines
+18
to
+19
| internal actual fun Memory.Companion.ofByteArray(src: ByteArray, offset: Int, length: Int): Memory = | ||
| Memory.of(src, offset, length) |
There was a problem hiding this comment.
Question: Why is this platform-dependent? Couldn't this be implemented in common instead?
There was a problem hiding this comment.
You'd think so but it does not exist in ktor-io common. I'm not sure why but I suspect some limitation of K/N as it exists today. But I agree which is why I defined the extension in common and figure it will resolve itself or we'll deal with it when the time comes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
fixes aws/aws-sdk-kotlin#147
Description of changes:
reserve()to take into account existing data. We were erroneously basing the new buffer size only on the incoming data and not including the amount already writtenasReadOnly()to create a read only view of a buffer which works similar toByteBuffer.asReadOnly()of()to create a buffer using an existingByteArrayorByteBufferas the backing memorygradle.propertiesversionsBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.