From fd7be4b86b8aabddd16bb93f3794a884d004c35e Mon Sep 17 00:00:00 2001 From: jonathan343 Date: Mon, 3 Nov 2025 23:34:50 -0500 Subject: [PATCH] Improve code-generated Config object docstring --- .../smithy/python/codegen/generators/ConfigGenerator.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/codegen/core/src/main/java/software/amazon/smithy/python/codegen/generators/ConfigGenerator.java b/codegen/core/src/main/java/software/amazon/smithy/python/codegen/generators/ConfigGenerator.java index 4aae8893f..a51e615fd 100644 --- a/codegen/core/src/main/java/software/amazon/smithy/python/codegen/generators/ConfigGenerator.java +++ b/codegen/core/src/main/java/software/amazon/smithy/python/codegen/generators/ConfigGenerator.java @@ -10,6 +10,7 @@ import java.util.List; import java.util.Locale; import java.util.TreeSet; +import software.amazon.smithy.aws.traits.ServiceTrait; import software.amazon.smithy.codegen.core.Symbol; import software.amazon.smithy.model.knowledge.EventStreamIndex; import software.amazon.smithy.model.knowledge.ServiceIndex; @@ -331,6 +332,11 @@ private void generateConfig(GenerationContext context, PythonWriter writer) { } var finalProperties = List.copyOf(properties); + final String serviceId = context.settings() + .service(context.model()) + .getTrait(ServiceTrait.class) + .map(ServiceTrait::getSdkId) + .orElse(context.settings().service().getName()); writer.pushState(new ConfigSection(finalProperties)); writer.addStdlibImport("dataclasses", "dataclass"); writer.write(""" @@ -352,7 +358,7 @@ def __init__( ${C|} """, configSymbol.getName(), - context.settings().service().getName(), + serviceId, writer.consumer(w -> writePropertyDeclarations(w, finalProperties)), writer.consumer(w -> writeInitParams(w, finalProperties)), writer.consumer(w -> documentProperties(w, finalProperties)),