Thread through BehaviorVersion to S3 Express identity provider
#3478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
Mar 12, 2024
...software/amazon/smithy/rust/codegen/client/smithy/generators/client/FluentClientGenerator.kt
Show resolved
Hide resolved
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
A follow-up task that resolves one of the
TODO(Post S3Express release)Description
This PR ensures that
BehaviorVersionis threaded through from an outer S3 client to the inner S3 client whenDefaultS3ExpressIdentityProvideris constructed.I considered the alternative where
BehaviorVersionwould be stored inConfigBagusing another flavor likeStoreOnceand obtained from the bag withinDefaultS3ExpressIdentityProvider::express_session_credentials. But ensuringStoreOnceperConfigBagwas not enough forBehaviorVersionsince there could be nestedConfigBags where eachConfigBagwas separate.BehaviorVersionneeds to be unique across those differentConfigBags and the fact that we storeBehaviorVersionoutsideRuntimeComponentsorConfigBagis a reasonable choice from that perspective (the ease of guaranteeing the uniqueness ofBehaviorVersion).Testing
Relied on existing tests in CI.
Checklist
CHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.