Thread through BehaviorVersion
to S3 Express identity provider
#3478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
A follow-up task that resolves one of the
TODO(Post S3Express release)
Description
This PR ensures that
BehaviorVersion
is threaded through from an outer S3 client to the inner S3 client whenDefaultS3ExpressIdentityProvider
is constructed.I considered the alternative where
BehaviorVersion
would be stored inConfigBag
using another flavor likeStoreOnce
and obtained from the bag withinDefaultS3ExpressIdentityProvider::express_session_credentials
. But ensuringStoreOnce
perConfigBag
was not enough forBehaviorVersion
since there could be nestedConfigBag
s where eachConfigBag
was separate.BehaviorVersion
needs to be unique across those differentConfigBag
s and the fact that we storeBehaviorVersion
outsideRuntimeComponents
orConfigBag
is a reasonable choice from that perspective (the ease of guaranteeing the uniqueness ofBehaviorVersion
).Testing
Relied on existing tests in CI.
Checklist
CHANGELOG.next.toml
if I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.