Skip to content

fix(core/event-streams): continue looking for event stream headers after payload is found #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2025
Merged

fix(core/event-streams): continue looking for event stream headers after payload is found #1792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/shy-colts-float.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@smithy/core": patch
---

continue looking for event headers after event payload is found
11 changes: 8 additions & 3 deletions packages/core/src/submodules/event-streams/EventStreamSerde.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,9 @@ describe(EventStreamSerde.name, () => {
"ns",
"CustomHeaders",
0,
["header1", "header2", "header-date", "header-number", "header-boolean", "header-blob"],
["payload", "header1", "header2", "header-date", "header-number", "header-boolean", "header-blob"],
[
[0, "ns", "BlobPayload", { eventPayload: 1 }, 21 satisfies BlobSchema] satisfies StaticSimpleSchema,
[0, "ns", "EventHeader", { eventHeader: 1 }, 0 satisfies StringSchema] satisfies StaticSimpleSchema,
[0, "ns", "EventHeader", { eventHeader: 1 }, 0 satisfies StringSchema] satisfies StaticSimpleSchema,

Expand Down Expand Up @@ -125,6 +126,7 @@ describe(EventStreamSerde.name, () => {
yield { TextPayload: { payload: "beep boop" } };
yield {
CustomHeaders: {
payload: new Uint8Array([0, 1, 2, 3]),
header1: "h1",
header2: "h2",
"header-date": new Date(0),
Expand Down Expand Up @@ -189,7 +191,7 @@ describe(EventStreamSerde.name, () => {
headers: {
":event-type": { type: "string", value: "CustomHeaders" },
":message-type": { type: "string", value: "event" },
":content-type": { type: "string", value: "application/cbor" },
":content-type": { type: "string", value: "application/octet-stream" },
header1: { type: "string", value: "h1" },
header2: { type: "string", value: "h2" },
"header-boolean": {
Expand All @@ -209,7 +211,7 @@ describe(EventStreamSerde.name, () => {
value: new Uint8Array([0, 1, 2, 3]),
},
},
body: {},
body: new Uint8Array([0, 1, 2, 3]),
},
];

Expand Down Expand Up @@ -346,6 +348,7 @@ describe(EventStreamSerde.name, () => {
yield { TextPayload: { payload: "boop beep" } };
yield {
CustomHeaders: {
payload: new Uint8Array([0, 1, 2, 3]),
header1: "h1",
header2: "h2",
"header-date": new Date(0),
Expand Down Expand Up @@ -400,6 +403,7 @@ describe(EventStreamSerde.name, () => {
{ TextPayload: { payload: "boop beep" } },
{
CustomHeaders: {
payload: new Uint8Array([0, 1, 2, 3]),
header1: "h1",
header2: "h2",
"header-boolean": false,
Expand Down Expand Up @@ -447,6 +451,7 @@ describe(EventStreamSerde.name, () => {
{ TextPayload: { payload: "boop beep" } },
{
CustomHeaders: {
payload: new Uint8Array([0, 1, 2, 3]),
header1: "h1",
header2: "h2",
"header-boolean": false,
Expand Down
1 change: 0 additions & 1 deletion packages/core/src/submodules/event-streams/EventStreamSerde.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,6 @@ export class EventStreamSerde {

if (eventPayload) {
explicitPayloadMember = memberName;
break;
} else if (eventHeader) {
const value = event[unionMember][memberName];
let type = "binary" as MessageHeaderValue["type"];
Expand Down