Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android Support #12

Closed
pentazoe opened this issue Apr 25, 2021 · 5 comments
Closed

Add Android Support #12

pentazoe opened this issue Apr 25, 2021 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@pentazoe
Copy link

Thank You for sharing such a nice and awaited feature

Description of the issue :
Currently it seems that it doesn't support Android
It doesn't let change "Animation Export Directory" of the "Animation Retargeting" Node from res:// which is not accessable when exported to Mobile Platform

@smix8
Copy link
Owner

smix8 commented Apr 26, 2021

I have to admit I have zero Android experience. I don't use it at all and have not a single android device to test so I never considered Android support.

That said, this doesn't mean that I wouldn't support it, if other people test it and tell me what is required to make it work for them.

Animation Export Directory is currently hardcoded to be a "res://" path but this can be changed. Is there any use case with exporting animations at runtime on Android? Last time I tested animations stored outside of the "res://" system they wouldn't work correctly on the exported game (the reason why "res://" path was hardcoded).

@smix8 smix8 added bug Something isn't working enhancement New feature or request labels Apr 26, 2021
@smix8
Copy link
Owner

smix8 commented Apr 26, 2021

Removed the hardcoded Animation Export Directory restrictions.
godot_3.x commit ef9a376
godot_4.x commit b9b10c5
godot_3.x_gdscript commit 8378848

@smix8 smix8 removed the bug Something isn't working label Apr 26, 2021
@pentazoe
Copy link
Author

Getting few errors on Android

04-27 04:04:17.617  5899  6002 E godot   : **ERROR**: Condition "!p_dst" is true. Returned: -1
04-27 04:04:17.617  5899  6002 E godot   :    At: platform/android/file_access_android.cpp:128:get_buffer() - Condition "!p_dst" is true. Returned: -1
04-27 04:04:17.872  5899  6002 E godot   : **ERROR**: Condition "!p_dst" is true. Returned: -1
04-27 04:04:17.872  5899  6002 E godot   :    At: platform/android/file_access_android.cpp:128:get_buffer() - Condition "!p_dst" is true. Returned: -1
04-27 04:04:17.876  5899  6002 E godot   : **ERROR**: Cannot get class 'AnimationRetargeting'.
04-27 04:04:17.876  5899  6002 E godot   :    At: core/class_db.cpp:1342:is_class_enabled() - Condition "!ti" is true. Returned: false
04-27 04:04:17.876  5899  6002 E godot   : **WARNING**: Node AnimationRetargeting of type AnimationRetargeting cannot be created. A placeholder will be created instead.
04-27 04:04:17.876  5899  6002 E godot   :    At: scene/resources/packed_scene.cpp:168:instance() - Node AnimationRetargeting of type AnimationRetargeting cannot be created. A placeholder will be created instead.
04-27 04:04:22.803  2059 10263 I PackageManager.DexOptimizer: Running dexopt (dexoptNeeded=1) on: /data/app/org.godotengine.test-HLE9AYJjjV8zP1jMc0oTJA==/base.apk pkg=org.godotengine.test isa=arm64 dexoptFlags=boot_complete,debuggable,public,enable_hidden_api_checks targetFilter=quicken oatDir=/data/app/org.godotengine.test-HLE9AYJjjV8zP1jMc0oTJA==/oat classLoaderContext=PCL[]
04-27 04:04:22.804  1280  2240 V installd: DexInv: --- BEGIN '/data/app/org.godotengine.test-HLE9AYJjjV8zP1jMc0oTJA==/base.apk' ---
04-27 04:04:22.863  6206  6206 I dex2oat : /apex/com.android.runtime/bin/dex2oat --input-vdex-fd=-1 --output-vdex-fd=11 --call-from-installd=1 --resolve-startup-const-strings=true --max-image-block-size=524288 --compiler-filter=quicken -j6 --debuggable --classpath-dir=/data/app/org.godotengine.test-HLE9AYJjjV8zP1jMc0oTJA== --class-loader-context=PCL[] --generate-mini-debug-info --compilation-reason=unknown
04-27 04:04:24.060  1280  2240 V installd: DexInv: --- END '/data/app/org.godotengine.test-HLE9AYJjjV8zP1jMc0oTJA==/base.apk' (success) ---
04-27 04:04:24.061  2059 10263 I PackageManagerServiceInjector: FirstUseActivity Pinning optimized code org.godotengine.test

Screenshot_20210427_041130

@smix8
Copy link
Owner

smix8 commented Apr 26, 2021

Android seems to require different build parameters. So far I couldn't find something valuable for this error or how to fix it. Maybe if someone from the Android crowd moves by and knows what to do that would be great.

@smix8 smix8 added the help wanted Extra attention is needed label Apr 26, 2021
@smix8
Copy link
Owner

smix8 commented May 9, 2021

Added to the feature tracker.

@smix8 smix8 closed this as completed May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants