-
Notifications
You must be signed in to change notification settings - Fork 11
Description
Version
110.99.2
Operating System
- All
- Linux
- macOS
- Windows
- Other Unix
OS Version
other Any Windows
Processor
No response
Component
Installation
Severity
Minor
Description of the problem
The MSI installers generated for SMLNJ do not have any versioning information.
This means that:
- In add/remove programs, the installed version is shown as 0.0.0.0. This stops third party software update checkers determining if SML is out of date.
- WinGet, the Microsoft official package manager, cannot properly support SMLNJ (I tried to make a PR for it, but every version will be indicated as 0.0.0.0, meaning nobody will ever be prompted to update).
The MSI itself needs to have the version number embedded into it at packaging time such that Windows understands what version is currently installed. This will fix everything.
Additional comments:
I have a pull request open with WinGet to add support for SML, such that any user of W10+ could just type "winget install StandardMLofNewJersey" and have the newest MSI installed, and they could update with "winget upgrade StandardMLOfNewJersey", but this won't work for as long as every version's MSI reports itself as 0.0.0.0.
Fix:
I believe that line 6 of /config/trunk/WinSetup/smlnj.wxs should somehow be fed the current version number.
Transcript
No response
Expected Behavior
No response
Steps to Reproduce
No response
Additional Information
No response
Email address
Comments from smlnj-gforge
Original smlnj-gforge bug number 302
Submitted via web form by Simon Hollingshead me@simonhollingshead.com on 2022-01-30 at 18:29:00
Keywords: msi, version