Skip to content

Type of Real.fromDecimal does not match the Basis Library #75

Description

@JohnReppy

Version

110.99

Operating System

  • All
  • Linux
  • macOS
  • Windows
  • Other Unix

OS Version

No response

Processor

Any

Component

Basis Library

Severity

Minor

Description of the problem

SML/NJ declares:

val fromDecimal : IEEEReal.decimal_approx -> real

The Basis Library declares:

val fromDecimal : IEEEReal.decimal_approx -> real option

https://smlfamily.github.io/Basis/real.html#SIG:REAL.toDecimal:VAL

Although Real.fromDecimal is not implemented, it would be useful if its type matched the Basis Library to aid portability of code. (A user may chose to provide their own implementation which would be easier if the signature REAL didn't need to be redeclared.)

Transcript

No response

Expected Behavior

No response

Steps to Reproduce

open Real;

Additional Information

No response

Email address

phil.clayton@veonix.com

Comments from smlnj-gforge

Original smlnj-gforge bug number 319

Submitted via web form by Phil Clayton phil.clayton@veonix.com on 2022-07-06 at 12:06:00

Keywords: reals

comment by @JohnReppy on 2022-07-06 13:26:00 +000 UTC

Fixed for 110.99.3 and 2022.1

Activity

added
basis-libproblem with Standard ML Basis library
bugSomething isn't working
floating-pointproblem related to floating-point operations
gforgebug (or feature request) ported from smlnj-gforge repository
on Jul 15, 2022
self-assigned this
on Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

basis-libproblem with Standard ML Basis librarybugSomething isn't workingfixed-in-110.99.3issues that will be fixed in the 110.99.3 versionfloating-pointproblem related to floating-point operationsgforgebug (or feature request) ported from smlnj-gforge repository

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions