Skip to content

config: restore PPC for 10.4 and 10.6 #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

barracuda156
Copy link
Contributor

Configure is missing settings for 10.4 and 10.6 for PowerPC, which causes the build to fail. These systems are still used, and have all developer tools needed to build smlnj.

I have confirmed it to build on 10.6 PPC (10A190) and 10.6.8 Rosetta. (Rosetta needs minor manual patching in order to convince the build system to ignore uname info and build for ppc32.)

@JohnReppy JohnReppy merged commit c93abc6 into smlnj:main Jun 14, 2023
@JohnReppy JohnReppy self-requested a review June 14, 2023 11:56
@JohnReppy JohnReppy self-assigned this Jun 14, 2023
@JohnReppy
Copy link
Contributor

This change looks okay; I do not remember removing those systems from the _arch-n-opsys script, so adding them back should not be a problem.

@JohnReppy JohnReppy added bug Something isn't working installation problem with installer fixed-in-110.99.4 issues that will be fixed in the 110.99.4 version labels Jun 14, 2023
@barracuda156 barracuda156 deleted the darwin branch June 14, 2023 12:23
@barracuda156
Copy link
Contributor Author

@JohnReppy Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed-in-110.99.4 issues that will be fixed in the 110.99.4 version installation problem with installer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants