PackReal64Big and PackReal64Little export internals - #349
Merged
Conversation
Skyb0rg007
force-pushed
the
pack-real-sigs
branch
from
March 22, 2025 21:18
636d3be to
9af5bf3
Compare
JohnReppy
approved these changes
Mar 26, 2025
JohnReppy
changed the title
PackReal64Big and PackReal64Little export internals.PackReal64Big and PackReal64Little export internals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added signatures to PackReal64{Big,Little} structures
Motivation and Context
Internal implementation details of these structures was not properly hidden behind a signature.
Now it has been fixed.
How Has This Been Tested?
This has not been tested at all, as I am having issues compiling the SML/NJ project on my machine.
I may send a bug report for that once I determine the cause.