Repository navigation
Fix Word8Buffer.contents to return an object with ByteVector representation - #351
Merged
Merged
Conversation
Skyb0rg007
force-pushed
the
word8buffer-fix
branch
from
April 1, 2025 19:50
d0509d9 to
88c478d
Compare
Skyb0rg007
force-pushed
the
word8buffer-fix
branch
from
April 1, 2025 19:59
88c478d to
a139bc7
Compare
Word8Buffer.contents to return an object with ByteVector representation
JohnReppy
added a commit
that referenced
this pull request
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description
This change fixes the issue by ensuring the
Word8Buffer.contentsfunction returns a value with theByteVectorobject representation (fromcreate_s), instead of theByteArrayrepresentation (fromcreate_b).How Has This Been Tested?
Not at all. Please test my code as I am unable compile SML/NJ myself due to an issue with the build system.