Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SExpParser.parseFile should return empty list on empty file #240

Closed
JohnReppy opened this issue Jul 16, 2022 · 0 comments
Closed

SExpParser.parseFile should return empty list on empty file #240

JohnReppy opened this issue Jul 16, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request fixed-in-2022.1 issue is fixed in the 2022.1 release gforge bug (or feature request) ported from smlnj-gforge repository

Comments

@JohnReppy
Copy link
Contributor

Description of the problem

When SExpParser.parseFile parses an empty file, it will fail with:

uncaught exception Fail [Fail: error [empty:1.1]: parsing value, found '']

This is somewhat unexpected. An empty file has no s-expressions, so
SExpParser.parseFile should be returning an empty list instead. Returning an
empty list also has the advantage of making it possible to distinguish between
parsing errors and empty files.

Comments from smlnj-gforge

Original smlnj-gforge bug number 307

Submitted on 2022-32-14 at 00:3200

comment by @JohnReppy on 2022-18-31 16:1800 +000 UTC

Fixed for 110.99.3 and 2022.1

comment by @JohnReppy on 2022-52-11 18:5200 +000 UTC

Moved to feature requests

comment by @JohnReppy on 2022-52-11 18:5200 +000 UTC

Moved from Bugs to Feature Requests

@JohnReppy JohnReppy added enhancement New feature or request gforge bug (or feature request) ported from smlnj-gforge repository labels Jul 16, 2022
@JohnReppy JohnReppy self-assigned this Jul 16, 2022
@JohnReppy JohnReppy added the fixed-in-2022.1 issue is fixed in the 2022.1 release label Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed-in-2022.1 issue is fixed in the 2022.1 release gforge bug (or feature request) ported from smlnj-gforge repository
Projects
None yet
Development

No branches or pull requests

1 participant