Fix IntBinarySet's comparison operators to be like BinarySetFn#308
Merged
Conversation
IntBinarySet's comparison operators to be like BinarySetFn
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
split_gt, IntBinarySet's comparison operators are reversed compared to the BinarySetFn's case expression.Related Issue
#310
Motivation and Context
For the function:
results in:
This results in a set with multiple duplicate numbers added in it. Also intersection doesn't work as expected. Since the SML.NET compiler uses
IntBinarySetfor its sets of symbols, the result is that after adding symbols to the set through unions, the same symbol appears 4 to 5 times in the set but does not show up when calling intersection with a set with that symbol. This results in it hanging forever when translating valid programs to MIL.How Has This Been Tested?
This program:
results in this afterwards:
SML.NET no longer hangs forever when compiling the raytrace and primes demo programs.
This issue also appears to be in the legacy SML/NJ repository.