Skip to content

fix: simplify docker build #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2023
Merged

fix: simplify docker build #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,5 +47,6 @@ jobs:
push: true
tags: ${{ steps.docker_metadata.outputs.tags }}
labels: ${{ steps.docker_metadata.outputs.labels }}
file: deploy/${{ matrix.binary }}/Dockerfile
file: Dockerfile
build-args: BINARY=${{ matrix.binary }}
context: dist/${{ env.GITHUB_REPOSITORY_NAME }}_linux_amd64_v1
28 changes: 16 additions & 12 deletions .goreleaser.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,29 +37,33 @@ signs:
artifacts: checksum

dockers:
- image_templates:
- "ghcr.io/{{ .Env.GITHUB_REPOSITORY }}/{{ .ArtifactName }}:{{ .Version }}-amd64"
- ids:
- go-cli-github
image_templates:
- "ghcr.io/{{ .Env.GITHUB_REPOSITORY }}/go-cli-github:{{ .Version }}-amd64"
use: buildx
dockerfile: deploy/{{ .ArtifactName }}/Dockerfile
build_flag_templates:
- "--build-arg=BINARY=go-cli-github"
- "--platform=linux/amd64"
- image_templates:
- "ghcr.io/{{ .Env.GITHUB_REPOSITORY }}/{{ .ArtifactName }}:{{ .Version }}-arm64v8"
- ids:
- go-cli-github
image_templates:
- "ghcr.io/{{ .Env.GITHUB_REPOSITORY }}/go-cli-github:{{ .Version }}-arm64v8"
use: buildx
goarch: arm64
dockerfile: deploy/{{ .ArtifactName }}/Dockerfile
build_flag_templates:
- "--build-arg=BINARY=go-cli-github"
- "--platform=linux/arm64/v8"

docker_manifests:
- name_template: "ghcr.io/{{ .Env.GITHUB_REPOSITORY }}/{{ .ArtifactName }}:{{ .Version }}"
- name_template: "ghcr.io/{{ .Env.GITHUB_REPOSITORY }}/go-cli-github:{{ .Version }}"
image_templates:
- "ghcr.io/{{ .Env.GITHUB_REPOSITORY }}/{{ .ArtifactName }}:{{ .Version }}-amd64"
- "ghcr.io/{{ .Env.GITHUB_REPOSITORY }}/{{ .ArtifactName }}:{{ .Version }}-arm64v8"
- name_template: "ghcr.io/{{ .Env.GITHUB_REPOSITORY }}/{{ .ArtifactName }}:latest"
- "ghcr.io/{{ .Env.GITHUB_REPOSITORY }}/go-cli-github:{{ .Version }}-amd64"
- "ghcr.io/{{ .Env.GITHUB_REPOSITORY }}/go-cli-github:{{ .Version }}-arm64v8"
- name_template: "ghcr.io/{{ .Env.GITHUB_REPOSITORY }}/go-cli-github:latest"
image_templates:
- "ghcr.io/{{ .Env.GITHUB_REPOSITORY }}/{{ .ArtifactName }}:{{ .Version }}-amd64"
- "ghcr.io/{{ .Env.GITHUB_REPOSITORY }}/{{ .ArtifactName }}:{{ .Version }}-arm64v8"
- "ghcr.io/{{ .Env.GITHUB_REPOSITORY }}/go-cli-github:{{ .Version }}-amd64"
- "ghcr.io/{{ .Env.GITHUB_REPOSITORY }}/go-cli-github:{{ .Version }}-arm64v8"

docker_signs:
- args:
Expand Down
5 changes: 3 additions & 2 deletions deploy/go-cli-github/Dockerfile → Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
FROM alpine:3.19@sha256:51b67269f354137895d43f3b3d810bfacd3945438e94dc5ac55fdac340352f48
ENTRYPOINT ["/go-cli-github"]
COPY go-cli-github /
ARG BINARY=binary-build-arg-not-defined
ENTRYPOINT ["/${BINARY}"]
COPY $BINARY /