Copying Dirty Fields

[Xowap]

The dirty fields mixin works fine for simple types like string, booleans or integers, however it fails when it comes to more complex objects like geometries or JSON fields.

Take the following model

class Test(models.Model):
    anchor = PointField()

Then do something like

t = Test.objects.get(id=1)
t.anchor.x = 42
t.get_dirty_fields()

In the current version, this returns an empty array. However with the attached patch, it will indeed return "anchor" as a changed field, with the correct previous value.

Technical choices for this patch are explained in details in efd0286.

There is also a bit of PEP8 formatting in 6b4dcee.

[dacresni]

wow, please send this patch to me

[Xowap]

what do you mean?

[dacresni]

I actually forked this because i didn't know this existed https://github.com/django/django/blob/1.5.7/django/forms/forms.py#L347 i can't accept a pull request directed at a different repo. I'm not sure if this repo is still relevant. knowing that django forms have this capability already, is having it on models still necessary?

[Xowap]

Yup it is needed for me, as I use TastyPie and almost no forms. Furthermore this is a warranty of getting stuff right at the smallest possible granularity in Django.

[Xowap]

PR sent

[romgar]

Hi @Xowap , as there are some issues with other types of fields, I will think about a global solution and keep you up-to-date.

[romgar]

PR #41 will fix this. Thanks for your help @Xowap