Skip to content

db v070#690

Merged
smnorris merged 77 commits into
mainfrom
db_070
Sep 24, 2025
Merged

db v070#690
smnorris merged 77 commits into
mainfrom
db_070

Conversation

@smnorris
Copy link
Copy Markdown
Owner

@smnorris smnorris commented Sep 8, 2025

  • use bcfishpass.observations and observation_key (vs observations_vw and unstable fish_observation_point_id)
  • reduce use of nested views
  • reduce use of fwa functions in view/materialized view queries

smnorris added 26 commits April 11, 2025 16:39
* main:
  update doc version tag
  update workflow
  error
  rename docs workflow
  docs deploy
  only update docs on push to main
  PSCIS DATAFIX_20250315 (#622)
* main:
  accommodate slower run times in testing workflow
* main:
  modelled_fixes_takl-stul-ltre_ (#641)
* main:
  doc formatting
  Review of crossings in the TABR, WILL, and LSAL watersheds (#675)
  add database and database contents licenses, fix #686 (#687)
@smnorris
Copy link
Copy Markdown
Owner Author

Output column observation_key_upstr is not actually used anywhere when generating outputs.
It could be dropped but is useful for QA.

@smnorris
Copy link
Copy Markdown
Owner Author

smnorris commented Sep 19, 2025

A simple fix would be to only include upstream observation keys within the same watershed group. Retaining trans-wsg boundary species observed is required to correctly code 'observed' habitat on trans-wsg rivers

@smnorris
Copy link
Copy Markdown
Owner Author

@andrewp-CWF I've tweaked the workflow to take the list of plans from bcfishpass.wcrp_watersheds - but auto_rank.py has a hard coded list of choices and current PR fails https://github.com/smnorris/bcfishpass/actions/runs/17867255026/job/50820187043

Is it ok to modify auto_rank.py to also pull the choices from bcfishpass.wcrp_watersheds?

@smnorris
Copy link
Copy Markdown
Owner Author

Ok, looking closer they are actually quite different lists. I'll revert to running auto_rank.py on the list that is present in that script and the existing workflow in the CWF repo.

@smnorris
Copy link
Copy Markdown
Owner Author

smnorris commented Sep 23, 2025

Latest failure appears unrelated to anything in the PR - the only change to the query that is timing out is a move from view streams_habitat_known_vw to table streams_habitat_known. New table is indexed the same as the view was. It seems something odd is going on with the connections to the db, these queries do not take that long (relatively speaking), and the point of failure is not consistent.

I'll call the script locally and QA results. If all looks fine I'll migrate the prod dbs and merge the PR. We'll see if db connection issues remain with the prod dbs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant