Skip to content

Conversation

@hsahovic
Copy link

@hsahovic hsahovic commented Nov 1, 2020

No description provided.

@hsahovic
Copy link
Author

hsahovic commented Nov 1, 2020

Oops, I did it again. Sorry about that - please disregard this PR.

@hsahovic hsahovic closed this Nov 1, 2020
@hsahovic hsahovic deleted the smogon-master branch November 1, 2020 23:58
@Zarel
Copy link
Member

Zarel commented Nov 2, 2020

I still think we can just integrate your fork into master. If you'd like, I can write the code myself.

@hsahovic
Copy link
Author

hsahovic commented Nov 2, 2020

That would be amazing :) How would you like to proceed?

@Zarel
Copy link
Member

Zarel commented Nov 2, 2020

I would probably add config settings for:

noThrottle - remove all code that prevents you from doing things too many times in a period of time

noAltChecking - remove all IP-based limits

noGuestAuthentication - remove the client signature authentication

And then a command-line flag --no-security to quickly remove all of the above.

@Zarel
Copy link
Member

Zarel commented Nov 2, 2020

Is this all you need? Am I missing anything?

@Zarel Zarel changed the title Smogon master poke-env support Nov 2, 2020
@hsahovic
Copy link
Author

hsahovic commented Nov 2, 2020

I think you got everything yep :) I just want to make sure noThrottle would also remove limits such as max number of concurrent challenges / battles, in addition to time-based limits

@Zarel
Copy link
Member

Zarel commented Nov 5, 2020

@mia-pi-git next is the command-line flag, ./pokemon-showdown start --no-security 8000

Do you want to handle that?

@mia-pi-git
Copy link
Member

@mia-pi-git next is the command-line flag, ./pokemon-showdown start --no-security 8000

Do you want to handle that?

#7648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants