New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to swagger-ui v3 #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. html largely outside my wheelhouse though
Thanks for reviewing @jadams74. I need to update to the latest UI build. |
Changes Unknown when pulling 2e0e77f on jp-swagger-ui3 into ** on master**. |
Jood job @jplock ! I will check the oauth2 part to see if everything is ok after the migration :) |
@akraxx do you want to checkout this branch to see if its still working? I haven't tested that part. |
Done in #83 , sorry had no time to do it before ! |
Upgrade oauth2 support to work with swagger v3
I'm waiting for this to be merged so I can use it in my project without having to build from a fork and use a local maven repo (difficult with Docker deployments). Any chance of it getting merged into the main line soon? |
@rstorey my main hesitation right now is that all of the integration tests are going to fail as soon as I merge this in (Travis doesn't execute those because they require Google Chrome right now). So I either have to update the tests (which I don't have time at the moment to do), or remove them (since they were testing that swagger itself was mostly working, I'm leaning toward just removing them). |
Gotcha. My opinion: removing the tests is okay. Since what they're actually testing isn't the code of this project, but its underlying dependency, and if any of the tests were to fail, it would be indicative of a problem that isn't necessarily fixable within this project. Thanks for replying. |
Ok let's do this |
Yay! Thank you! |
The swagger v3 UI is very different than the v2 version. I'm not sure when it would be best to merge this in but my guess is v2 is no longer supported.