Join GitHub today
Refine handling of illegal characters in userinfo #70
@smola I added a test for this back at 5e68451#diff-d044dce65d9dfb982ad24b58dabeb501. So that test is now already on the master branch at https://github.com/smola/galimatias/blob/master/src/test/resources/data/urltestdata_whatwg.txt#L331 (the last test in that file).
Should I also add it in ParseIssueTest?
Anyway, to be clear: That test passes both before and after this change. In other words, the patch in this PR doesn’t change the behavior of the existing test when run under the test harness here.
However, it can change the behavior of tests run by consuming code. For example, the test suite I use for the HTML checker (validator) has the following test: https://github.com/web-platform-tests/wpt/blob/master/conformance-checkers/html/elements/a/href/userinfo-username-contains-pile-of-poo-novalid.html. When I run that test without the patch in this PR/branch applied, it incorrectly reports the problem character as