-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CJK chars work finally #255
Conversation
There are still some words that can not be correctly rendered, hope it is helpful for you debgging:
|
@SilverRainZ Would you mind explaining what renders incorrectly about those characters? They seem to look fine on my end: The only reason I'd guess they wouldn't render correctly would be if there were lots of different chars in use in a single file (something I guess could happen pretty often?), and the font atlas could perhaps get filled, causing rendering issues. Might need to work in some way of knowing when that happens and increasing the font atlas size if necessary; but I don't know if that's what's happening for you there? |
Just to make sure, it's the bold markup |
Sorry, it is just for emphasizing, and does not related to this issue. |
Hmm, well since you can't reproduce it anymore, I'll just go ahead and merge this. Feel free to open an issue if the problem re-appears/persists! |
@SilverRainZ Just a note, I think I was able to fix the issue you were running into via 3f26610; for me the issue looked something like this, although it varied: In that screenshot you can also see the font atlas, and how the char gets cut off at the edge of the canvas there, causing the char to appear incorrectly. A look at the code revealed I had forgotten to account for double width chars at the edge of the font atlas, and that was the result. So should be fixed in that commit I linked above (and thus on master). |
Still needs some work but I'm fairly confident I can finally fix #140 with this.
@SilverRainZ would you mind giving this branch a test? The chars (both Latin and CJK) aren't displayed perfectly (still need some tweaking on that front I think), but it seems to mostly display CJK chars properly from my testing.