GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
As RVM creates folders using the % sign to separate ruby version and gemset, it breakes URI.parse:
I have updated envjs to use URI.escape before parsing the file name, so it will escape the % sign. Tests pass here after this change, but I don't know how I could add a test to it.
I'm sending a pull request with the changes in my fork, please take a look.
Thanks! Should be able to get to it tomorrow ....
I think this will result in double escaping for real URLs that have escape sequences in them.
Could you look at maybe catching the exception that URI.parse throws and in that specific case, creating a file URI, sort of like the heuristic is doing now?
Hum... okay.. I'll take a look on that...
Steven, I noticed by updating my rvm installation (a bit old huh?) that it now uses @ instead of %, so it won't break with env-js anymore. So the solution is to update rvm.
I guess you can close this issue.
Thanks for your help and time.
Cool. Good to avoid %s in filenames (hadn't thought of that before); glad RVM got tweaked.
envjs should probably allow %'s in paths that dont' start as URIs, but we can make it lower priority.