New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'timer error' raised from event_loop.js #23

Closed
chrisroos opened this Issue Nov 5, 2010 · 5 comments

Comments

Projects
None yet
2 participants
@chrisroos

chrisroos commented Nov 5, 2010

I've got a fairly complete example of the problem in https://github.com/chrisroos/capybara-envjs-rack-test. I haven't had a go at writing a failing test or a fix. The reason is that the rhino version of envjs doesn't suffer from this same problem and I think it'd be a better use of time to bring the two versions back in sync rather than fixing specific problems in this version. I'm going to follow this up on the mailing list too, to see whether I can be of any help in bringing the versions back in sync.

@smparkes

This comment has been minimized.

Show comment
Hide comment
@smparkes

smparkes Nov 5, 2010

Owner

Fixed.

Owner

smparkes commented Nov 5, 2010

Fixed.

@smparkes

This comment has been minimized.

Show comment
Hide comment
@smparkes
Owner

smparkes commented Nov 5, 2010

@chrisroos

This comment has been minimized.

Show comment
Hide comment
@chrisroos

chrisroos Nov 5, 2010

Hey, that's great, cheers Steven. Just one thing though... Although I no longer get the 'timer error', clicking the link to visit a fragment doesn't update the window.location as I'd expect.

You may have already seen it but I've posted a message to the envjs group[1] asking whether I can help get the johnson version of envjs back into line with the rhino version.

[1] http://groups.google.com/group/envjs/browse_thread/thread/ec2ba83d0fb3e57c

chrisroos commented Nov 5, 2010

Hey, that's great, cheers Steven. Just one thing though... Although I no longer get the 'timer error', clicking the link to visit a fragment doesn't update the window.location as I'd expect.

You may have already seen it but I've posted a message to the envjs group[1] asking whether I can help get the johnson version of envjs back into line with the rhino version.

[1] http://groups.google.com/group/envjs/browse_thread/thread/ec2ba83d0fb3e57c

@smparkes

This comment has been minimized.

Show comment
Hide comment
@smparkes

smparkes Nov 6, 2010

Owner

I'm not sure about the hash thing. If I print window.location in your renderAjaxReponse, I get the url with the hash and did a quick code inspection of the relevant paths, and they should be setting the url. Do you have a test case?

Also, I've never seen the double location set issue you mentioned in the git repo. Does the right thing for me first time and doesn't print the errors.

Owner

smparkes commented Nov 6, 2010

I'm not sure about the hash thing. If I print window.location in your renderAjaxReponse, I get the url with the hash and did a quick code inspection of the relevant paths, and they should be setting the url. Do you have a test case?

Also, I've never seen the double location set issue you mentioned in the git repo. Does the right thing for me first time and doesn't print the errors.

@chrisroos

This comment has been minimized.

Show comment
Hide comment
@chrisroos

chrisroos Nov 7, 2010

Ah, you're right. I did have a failing test[1] but the test itself wasn't quite right. I was using Capybara's current_path method which obviously ignores the fragment part of the URL. I changed the test to use current_url and can see that the fragment is indeed appended to the URL. Cheers for your help Steven.

[1] https://github.com/chrisroos/capybara-envjs-rack-test/blob/master/test/envjs_rack_app_test.rb

chrisroos commented Nov 7, 2010

Ah, you're right. I did have a failing test[1] but the test itself wasn't quite right. I was using Capybara's current_path method which obviously ignores the fragment part of the URL. I changed the test to use current_url and can see that the fragment is indeed appended to the URL. Cheers for your help Steven.

[1] https://github.com/chrisroos/capybara-envjs-rack-test/blob/master/test/envjs_rack_app_test.rb

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment