Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

basicheaders, add reject option, loglevel #17

Merged
merged 5 commits into from May 23, 2012

Conversation

Projects
None yet
2 participants
Owner

msimerson commented May 23, 2012

added reject option
document the existence of the loglevel option
factored date validity tests into their own sub
added tests
improved POD
added whitelist support

msimerson added some commits May 21, 2012

basicheaders, add reject option, loglevel
added reject option
document the existence of the loglevel option
factored date validity tests into their own sub
added tests
improved POD
basicheaders: added whitelist support
because alerts.etrade.com doesn't set a Date header in alerts

abh commented on UPGRADING in 521aa49 May 23, 2012

Why deprecate the old option? You already made it work, just remove the deprecation warning and change the docs to recommend/suggest using the more detailed controls.

Owner

msimerson replied May 23, 2012

Because I don't see any setting for 'days' as being a reasonable. Anything more than 2 days in the future is obviously invalid, but anything less than 5 days in the past is too strict.

Owner

msimerson replied May 23, 2012

I have removed the deprecated warning. 'days' was originally an unnamed argument. It still works, and the warnings are removed, and only the new options are documented. Sufficient?

abh replied May 23, 2012

I like it – we want to make it easy for people to upgrade and with all the changes to integrate it'll already be hard for anyone with too many custom patches. Thanks!

abh added a commit that referenced this pull request May 23, 2012

Merge pull request #17 from msimerson/basic
basicheaders, add reject option, loglevel

@abh abh merged commit 1fd65b8 into smtpd:master May 23, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment