Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Command.handle broken (commit gone) #24

Closed
rduplain opened this Issue · 5 comments

3 participants

Ron DuPlain Michael Elsdörfer Sean Lynch
Ron DuPlain
Collaborator

What happend to commit?

https://bitbucket.org/asksol/flask-script/changeset/602d63f80d61

You pulled it, but now it doesn't work anymore.
This breaks Flask-Celery.

I will have make Flask-Celery force install an older version until this is fixed.
Thanks, in advance!


Michael Elsdörfer

This is a duplicate of #16. I had a patch on Bitbucket which restores this commit, and I'd be happy to port it to the current state.

I care about this issue because it allows removal of the terrible capture_all_args mode that I contributed a while ago, but which really isn't necessary with Ask's changes. Removing it is a backwards-incompatibility, which is why I wish this had happened 18 months ago.

Ron DuPlain
Collaborator

Flask-Script 0.3.2 fixes this. Is there still an open issue here?

Michael Elsdörfer

I don't think it does. The change is not in the current codebase. The point of it is to move the argument parsing from the Manager to the Command class, so that a command can do argument parsing in an entirely different way if it wants to.

I (and I believe Ask as well) would like to use this to wrap command lines from third party libraries.

Michael Elsdörfer

To clarify further: Yes, the Command class now has a handle method, but it receives an already preparsed Namespace instance, the actual parsing is still done in Manager.handle.

Ron DuPlain
Collaborator

To clarify the current release: Flask-Celery 2.4.2 no longer uses the Flask-Script-fix package, as it works against Flask-Script 0.3.2 and up (confirmed by Ask on #pocoo today). As you point out, there's still work to be done in moving all parsing to the Command class.

Thanks.

Sean Lynch techniq closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.