Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Better error handling in requestCallback #4

Merged
merged 1 commit into from Mar 3, 2013

Conversation

Projects
None yet
2 participants
Contributor

mpj commented Mar 2, 2013

If an exception happened inside the callback, it was caught by the catch outside the callback, and then the error was sent to the callback. Brainmelt. :P I've fixed it so that it only catches the parsing errors.

Mattias Petter Johansson Better error handling in requestCallback
If an exception happened inside the callback, it was caught by the catch outside the callback, and then the error was sent to the callback. Brainmelt. :P I've fixed it so that it only catches the parsing errors.
9c4104d

@smurthas smurthas added a commit that referenced this pull request Mar 3, 2013

@smurthas smurthas Merge pull request #4 from mpj/patch-1
Better error handling in requestCallback
5fb9f80

@smurthas smurthas merged commit 5fb9f80 into smurthas:master Mar 3, 2013

Owner

smurthas commented Mar 3, 2013

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment