From 8c0be9da4905d1cc8c88942a6fbc63223600f6b4 Mon Sep 17 00:00:00 2001 From: Luke Gorrie Date: Tue, 14 Jun 2016 05:19:25 +0000 Subject: [PATCH] connectx4: Comment on ommitted SET_DRIVER_VERSION --- src/apps/mellanox/connectx4.lua | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/apps/mellanox/connectx4.lua b/src/apps/mellanox/connectx4.lua index 89560c5699..385afb5b2e 100644 --- a/src/apps/mellanox/connectx4.lua +++ b/src/apps/mellanox/connectx4.lua @@ -49,6 +49,18 @@ -- this driver without signatures. It seems potentially futile -- to calculate and include command signatures if they are not -- actually being verified by the device. +-- +-- DRIVER VERSION: This driver does /not/ identify itself via the +-- command SET_DRIVER_VERSION. That interation could lead to +-- hazards in the spirit of HTTP User-Agent where the adapter +-- firmware would behave differently depending on how the +-- driver identifies itself. +-- +-- This decision could be revisited in the future when the +-- motivation for this mechanism is better understood. (The +-- card and firmware being used for initial development is not +-- asking the driver to identify itself anyway.) + module(...,package.seeall)