use parentNode instead of parentElement #210

Merged
merged 4 commits into from Jan 3, 2017

Projects

None yet

2 participants

@aronallen

In IE11 children and parentElement are undefined for SVG elements.
Instead childNodes and parentNode should be used.

@paldepind
Member

Does this happen only in IE11? Would you maybe add a test as well for the problem?

@aronallen

I believe it is IE11 only. I don't have access to my IE11 machine right now.
It should be quite simple to write a test for the HTMLDOM API.

@aronallen

@paldepind I wrote a test now. This is quite critical for us, as our application breaks in SVG when drawing charts.

@paldepind
Member

Great! Thanks for the PR.

I plan on doing the next release in ~ 1 week.

@paldepind paldepind merged commit 7da8662 into snabbdom:master Jan 3, 2017
@aronallen

@paldepind det var så lidt.

@aronallen aronallen referenced this pull request in cyclejs/cyclejs Jan 9, 2017
Closed

upgrade to snabbdom 6.1 #506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment