ProductDatabase: Fix app crash due to SQLiteDatabaseLockedException #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase` and throwing IOException after it has been handled
cmaier
approved these changes
Feb 21, 2024
Co-authored-by: Christian Maier <cmaier@users.noreply.github.com>
# Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
Wrapped the opening of the db in a try..catch block, to handle SQLiteDatabaseLockedException's.
After Logging the error an IO-Exeptions is thrown instead (since this is the way already used there and handled)
How to test?
I couldn't reproduce the bug. But it should fix it.
For more details see Apps-1367
Definition of Done