Skip to content

Conversation

@cmaier
Copy link
Contributor

@cmaier cmaier commented Mar 26, 2024

The Snabble object now holds an object FormPrefillData that can be set and if so is used to prefill the web from in PayoneInputView.

APPS-1356 (APPS-1493)

How to test?

Install an app making use of this feature - it has to the set field Snabble.formPrefillData and have Payone as payment provider enabled.

Definition of Done

  • Changelog gepflegt
  • Dokumentation gepflegt
  • Alle Anforderung des Issues sind erfüllt
  • Selbst greviewed (aka Self-Reviews (eng))
  • Review mit Product Owner (Release-Variante o. Minified Build)

App Tests

  • Minified getestet? (aka. Release Build)
  • Environments beachtet (Production/Staging)
  • Unterstützte Sprachen sind getestet
  • Light-/Dark-Mode getestet
  • Edge-Cases getestet
  • Android API Levels wurden berücksichtigt (minSdk?)

Testing

  • Tests geschrieben (aka Unit-Tests, Integration-Tests)
  • Tests lokal laufen gelassen

@cmaier cmaier requested a review from Fabtron March 26, 2024 18:59
@cmaier cmaier self-assigned this Mar 26, 2024
Copy link
Collaborator

@Fabtron Fabtron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine except one little bug.
For some reason this part

.form-group:has(select:disabled) {
    display: none;
}

is not working with the new logic, leading to the state selection always displayed.

@cmaier
Copy link
Contributor Author

cmaier commented Mar 28, 2024

Works fine except one little bug. For some reason this part

.form-group:has(select:disabled) {
    display: none;
}

is not working with the new logic, leading to the state selection always displayed.

Refactored the CSS-way using JavaScript. The has-selector from CSS is too new.

@cmaier cmaier requested a review from Fabtron March 28, 2024 10:25
Copy link
Collaborator

@Fabtron Fabtron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@cmaier cmaier merged commit 86c5c46 into main Mar 28, 2024
@cmaier cmaier deleted the apps-1493-autofill-payone-credit-card-form branch March 28, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants