Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid superfluous calls of conda info that have slowed down Snakemake since 6.4.1. #1099

Merged
merged 1 commit into from Jul 19, 2021

Conversation

johanneskoester
Copy link
Contributor

@johanneskoester johanneskoester commented Jul 19, 2021

Description

In 6.4.1 we had refactored the Conda class, which accendentally led to superfluous calls of conda info. This is fixed now.
Many thanks to @christopher-schroeder for spotting the issue and narrowing down to the Snakemake version that introduced the fix.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit e990927 into main Jul 19, 2021
7 checks passed
@johanneskoester johanneskoester deleted the cache-conda-info branch Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant