fix: Use 'snakemake.utils.update_config' instead of 'dict.update' #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
2 tasks
|
@johanneskoester Any thoughts on this? :-) |
johanneskoester
approved these changes
Oct 21, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
|
Soemthing fails on windows now. Do you have a clue? |
|
Not really, and I don't have any Windows machine to investigate this :-( |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks a lot, finally done :-). |
|
Wonderful! Thanks a lot for the debugging as well :-) |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When merging configs, Snakemake uses
dict.updateinstead ofsnakemake.utils.update_configwhich is not recursive.Nested config options can thus disappear unexpectedly.
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).