New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ga4gh tes bugfixes #1127
fix: Ga4gh tes bugfixes #1127
Conversation
setup.py
Outdated
@@ -76,6 +76,7 @@ | |||
"filelock", | |||
"stopit", | |||
"tabulate", | |||
"py-tes", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this needs to be a required dependency. But the docs should probably say that py-tes needs to be installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And the import statement here should be wrapped in a try-except with a WorkflowError("Unable to import Python package tes. TES backend requires py-tes to be installed. Please install py-tes, e.g. via Conda or Pip.")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I added a try-except statement in the init function. I will also a note at the documentation
Please format your code with black: |
Kudos, SonarCloud Quality Gate passed!
|
Thank you! |
Description
This PR contains two bugfixes
QC
docs/
) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).