Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bugfix tes add files #1133

Merged
merged 8 commits into from Aug 17, 2021
Merged

fix: Bugfix tes add files #1133

merged 8 commits into from Aug 17, 2021

Conversation

svedziok
Copy link
Contributor

@svedziok svedziok commented Aug 13, 2021

Description

Due to an insufficient test, a new bug was introduced with the recent patch. This PR contains a fix and improves the test.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@svedziok svedziok requested a review from johanneskoester as a code owner Aug 13, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 13, 2021

Please format your code with black: black snakemake tests/*.py.

@svedziok svedziok marked this pull request as draft Aug 13, 2021
@svedziok svedziok marked this pull request as ready for review Aug 13, 2021
@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@svedziok
Copy link
Contributor Author

svedziok commented Aug 17, 2021

@johanneskoester thanks for approval; it can be merged now

@johanneskoester johanneskoester merged commit 8892bf2 into main Aug 17, 2021
6 checks passed
@johanneskoester johanneskoester deleted the bugfix_tes_add_files branch Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants