Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: async_run to allow nested event loops. #1170

Merged
merged 2 commits into from Sep 24, 2021

Conversation

ashwinvis
Copy link
Contributor

@ashwinvis ashwinvis commented Sep 10, 2021

Fixes: #1105

Description

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@ashwinvis ashwinvis requested a review from johanneskoester as a code owner Sep 10, 2021
@ashwinvis ashwinvis changed the title Fix async_run to allow nested event loops. fix: async_run to allow nested event loops. Sep 10, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester
Copy link
Contributor

johanneskoester commented Sep 24, 2021

Thanks a lot!

@johanneskoester johanneskoester merged commit 5dc6bbd into snakemake:main Sep 24, 2021
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snakemake API throws RuntimeError related to asyncio when used within Jupyter
2 participants