Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wms monitor arg ints #1181

Merged

Conversation

Tobias-Ternent
Copy link
Contributor

@Tobias-Ternent Tobias-Ternent commented Sep 17, 2021

Description

Fixing an issue I was experiencing when passing in wms-monitor-arg values, it was casting everything to integers, and I want to be able to pass in other things like Strings. So just removing usage of the parse_resources() in the WMS logger.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@Tobias-Ternent Tobias-Ternent changed the title Bugfix/wms monitor arg ints fix/wms monitor arg ints Sep 17, 2021
@Tobias-Ternent Tobias-Ternent changed the title fix/wms monitor arg ints fix: wms monitor arg ints Sep 17, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fgypas
Copy link
Member

fgypas commented Sep 17, 2021

Thanks a lot @Tobias-Ternent . I just tested the changes and it works fine for me.

@vsoch I think it would be great to have your input and make sure that no breaking changes are introduced for snakeface.

@fgypas fgypas requested a review from vsoch Sep 17, 2021
vsoch
vsoch approved these changes Sep 17, 2021
Copy link
Contributor

@vsoch vsoch left a comment

I think this should be ok! If there is an issue with snakeface it will pop up and we can address at that time.

@fgypas
Copy link
Member

fgypas commented Sep 22, 2021

@johanneskoester It would be great if you can include this fix for the next release.

@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit 313de93 into snakemake:main Oct 21, 2021
6 checks passed
pvandyken pushed a commit to pvandyken/snakemake that referenced this pull request Nov 15, 2021
…#1181)

* Fixes snakemake#1180. No longer casting WMS args as integers.

* Fixes snakemake#1180. Removing unused parse_resources() import.

* Fixing WMS args parsing.

* Removed unused imports.

Co-authored-by: terneto1 <tobias.ternent@novartis.com>
Co-authored-by: Johannes Köster <johannes.koester@uni-due.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants