Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Run dependencies with non-existent ancient files earlier #1202

Merged
merged 2 commits into from Oct 21, 2021

Conversation

DonFreed
Copy link
Contributor

@DonFreed DonFreed commented Oct 1, 2021

Fixes #946

Description

During DAG creation, ancient() input files are not added to _n_until_ready, regardless of whether the input file exists. This PR adds ancient() input files to _n_until_ready if they do not exist.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@DonFreed DonFreed requested a review from johanneskoester as a code owner Oct 1, 2021
@DonFreed DonFreed changed the title Run dependencies with non-existent ancient files earlier fix: Run dependencies with non-existent ancient files earlier Oct 1, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester johanneskoester merged commit 84d1f64 into snakemake:main Oct 21, 2021
6 checks passed
@DonFreed DonFreed deleted the ancient_dag_order branch Oct 21, 2021
pvandyken pushed a commit to pvandyken/snakemake that referenced this pull request Nov 15, 2021
…uming job (snakemake#1202)

Fixes snakemake#946

Co-authored-by: Johannes Köster <johannes.koester@uni-due.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ancient keyword causes incorrect scheduling order
2 participants